Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): add source columns to rw_columns #14939

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Feb 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Not sure whether source columns should be included in rw_columns. But as the columns of sinks are encompassed, I suppose source columns should also be included.

Example:

> create source src (v int) with (
            connector = 'datagen',
            fields.v.kind = 'sequence',
            fields.v.start = '1',
            fields.v.end  = '10',
            datagen.rows.per.second='15',
            datagen.split.num = '1'
        ) FORMAT PLAIN ENCODE JSON;

> SELECT column_name, data_type, table_name FROM information_schema.columns WHERE 
            table_schema = 'public';
 column_name | data_type | table_name 
-------------+-----------+------------
 v           | integer   | src

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KeXiangWang KeXiangWang force-pushed the wkx/add-source-in-rw_columns branch from d7807f4 to 826b904 Compare February 2, 2024 00:54
@KeXiangWang KeXiangWang enabled auto-merge February 2, 2024 00:54
@KeXiangWang KeXiangWang added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 606972e Feb 2, 2024
30 of 31 checks passed
@KeXiangWang KeXiangWang deleted the wkx/add-source-in-rw_columns branch February 2, 2024 02:04
KeXiangWang added a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants